DB::repair: pass Options by ref#350
Merged
Merged
Conversation
Author
|
CI failure seems spurious. |
aleksuss
reviewed
Nov 9, 2019
| Ok(()) | ||
| } | ||
|
|
||
| pub fn repair<P: AsRef<Path>>(opts: Options, path: P) -> Result<(), Error> { |
Member
There was a problem hiding this comment.
What is a point ? Do we need to use Options after repairing ?
Author
There was a problem hiding this comment.
Yes, that's exactly what we do:
let db_corrupted = Path::new(path).join(Database::CORRUPTION_FILE_NAME);
if db_corrupted.exists() {
DB::repair(&opts, path)?;
// ^^^^^
}
// ...
DB::open_cf(&opts, path, &cfnames)
4 tasks
vitvakatu
approved these changes
Nov 11, 2019
|
No reason not to accept something via ref if it's possible. |
aleksuss
approved these changes
Nov 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change.