Restrict the stdweb feature to the wasm32-unknown-unknown target #352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pitdicker
force-pushed
the
restrict_stdweb_feature
branch
from
b681f96 to
adc36d8
Compare
dhardy
approved these changes
Mar 29, 2018
Member
dhardy
left a comment
dhardy
left a comment
There was a problem hiding this comment.
Looks good. Unfortunately it seems stdweb is broken.
Contributor
Author
|
Do you want to wait for stdweb to get fixed? I don't see something in the pipeline there yet. |
Member
|
No, I guess not since otherwise more tests are broken. |
pitdicker
pushed a commit
that referenced
this pull request
Apr 4, 2018
Restrict the stdweb feature to the wasm32-unknown-unknown target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://travis-ci.org/rust-lang-nursery/rand/jobs/359227191.
Building with
--all-featurestries to use stdweb, even when the target platform is not WASM.For
cargo doc --no-deps --all --all-featuresthat makes the CI a bit less optimal.