make_rng: document panic and add #[track_caller]#1761
Merged
dhardy merged 3 commits intorust-random:masterfrom Apr 9, 2026
Merged
make_rng: document panic and add #[track_caller]#1761dhardy merged 3 commits intorust-random:masterfrom
dhardy merged 3 commits intorust-random:masterfrom
Conversation
Member
Except |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
Document that
make_rngcan panic, and add#[track_caller]to improve panic diagnostics.Motivation
make_rngcallsexpecton the result ofSysRngseeding, but had no# Panicssection in its doc comment. This is inconsistent with the rest of the crate where panicking functions document the conditions (e.g.random_range,random_bool,random_ratio), and the#[track_caller]convention established in #1447.Details
# Panicssection following the existing crate style#[track_caller]so panics point to the call site rather than theexpectinsidemake_rng