Impl fill_via_chunks without using zerocopy or unsafe #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reduce the use of `zerocopy` as a step towards eliminating the dependency.
dhardy
force-pushed
the
push-vwmtzowklllx
branch
2 times, most recently
from
3e5cbe0 to
2b9763f
Compare
benjamin-lieser
approved these changes
Feb 25, 2025
dhardy
force-pushed
the
push-vwmtzowklllx
branch
from
2b9763f to
0680e6d
Compare
1 task
josephlr
approved these changes
Feb 27, 2025
Member
josephlr
left a comment
josephlr
left a comment
There was a problem hiding this comment.
LGTM. I confirmed in Godbolt that this compiles down to 1/2 memcpy's (depending on if the tail case triggers or not) for both u32 and u64.
newpavlov
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdentrySummary
I updated #1575 as suggested in that PR, choosing to keep
memcpyin the tail case.