Derive Debug in more places (requires Rust 1.70)
#851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phip1611
approved these changes
Jun 10, 2023
nicholasbishop
force-pushed
the
bishop-auto-dbg
branch
from
b52575f to
6ab50f4
Compare
nicholasbishop
force-pushed
the
bishop-auto-dbg
branch
from
6ab50f4 to
f8b4b40
Compare
nicholasbishop
force-pushed
the
bishop-auto-dbg
branch
from
f8b4b40 to
f41b9df
Compare
nicholasbishop
force-pushed
the
bishop-auto-dbg
branch
2 times, most recently
from
1663f83 to
e7310fc
Compare
nicholasbishop
force-pushed
the
bishop-auto-dbg
branch
2 times, most recently
from
09362b2 to
8d47b8c
Compare
Note that this requires rust>=1.70 for deriving `Debug` on `efiapi` function pointers.
Note that this requires rust>=1.70 for deriving `Debug` on `efiapi` function pointers.
Note that this requires rust>=1.70 for deriving `Debug` on `efiapi` function pointers.
nicholasbishop
force-pushed
the
bishop-auto-dbg
branch
from
8d47b8c to
2c2f798
Compare
|
Nice! :) thanks for taking care of this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Rust 1.70, deriving
Debugonefiapifunction pointers is supported. That means we can deriveDebugin a lot more places (tables and protocols).This requires an MSRV bump to 1.70, so per https://github.com/rust-osdev/uefi-rs/blob/main/uefi/README.md#msrv we should wait until Rust 1.72 is released to merge this.
Checklist