Skip to content

Directory::read_entry_boxed plus common abstraction make_boxed #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phip1611 merged 5 commits into from
Nov 24, 2022
Merged

Directory::read_entry_boxed plus common abstraction make_boxed #559

phip1611 merged 5 commits into from
Nov 24, 2022

Conversation

@phip1611
Copy link
Member

@phip1611 phip1611 commented Nov 12, 2022 •
edited
Loading

This adds a function to Directory to get directory entry information as boxed/owned values. This is done similar to File::get_boxed_info [commit1]. Unfortunately, the code is almost identical. I tried to create a new commonly shared abstraction [commit2]. However, it is not that easy to let it compile successfully. I'm seeking for advice.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 changed the title Directory::read_entry_boxed plus common abstraction for make boxed Directory::read_entry_boxed plus common abstraction make_boxed Nov 12, 2022
phip1611
phip1611 commented Nov 12, 2022
View reviewed changes
@phip1611 phip1611 marked this pull request as ready for review November 13, 2022 13:51
@phip1611 phip1611 self-assigned this Nov 13, 2022
@phip1611
Copy link
Member Author

phip1611 commented Nov 13, 2022 •
edited
Loading

This just left it's draft state.

Do you like the make_boxed abstraction?

phip1611
phip1611 commented Nov 13, 2022
View reviewed changes
@phip1611 phip1611 force-pushed the dir-info-boxed branch 3 times, most recently from 8e56867 to 4ee1c21 Compare November 14, 2022 10:00
@phip1611
Copy link
Member Author

phip1611 commented Nov 14, 2022 •
edited
Loading

I'm really looking forward to bumping the MSRV soon. Again, I had to alter my PR because of that 😀 @nicholasbishop @GabrielMajeri 7ce93f1

@phip1611 phip1611 force-pushed the dir-info-boxed branch 4 times, most recently from dfd07b3 to c6d7297 Compare November 20, 2022 18:52
nicholasbishop
nicholasbishop reviewed Nov 20, 2022
View reviewed changes
@phip1611 phip1611 force-pushed the dir-info-boxed branch 2 times, most recently from b681a4a to c7a04c8 Compare November 20, 2022 19:12
nicholasbishop
nicholasbishop requested changes Nov 20, 2022
View reviewed changes
@phip1611 phip1611 force-pushed the dir-info-boxed branch 2 times, most recently from 6bd7dcd to e1ca2c8 Compare November 20, 2022 23:00
@phip1611 phip1611 mentioned this pull request Nov 20, 2022
Closed
@phip1611
Copy link
Member Author

phip1611 commented Nov 23, 2022 •
edited
Loading

Any update here, @nicholasbishop?

I need it for #472 by the way.

@nicholasbishop
Copy link
Member

nicholasbishop commented Nov 23, 2022

Code looks good to me. One remaining thing though, read_entry_boxed should get a changelog entry.

@phip1611
Copy link
Member Author

phip1611 commented Nov 24, 2022 •
edited
Loading

Code looks good to me. One remaining thing though, read_entry_boxed should get a changelog entry.

I updated the changelog and I take your words as approval.

@phip1611 phip1611 merged commit 3a70961 into rust-osdev:main Nov 24, 2022
@phip1611 phip1611 deleted the dir-info-boxed branch November 24, 2022 08:43
@phip1611 phip1611 mentioned this pull request Nov 24, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nicholasbishop nicholasbishop Awaiting requested review from nicholasbishop

Assignees

@phip1611 phip1611

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phip1611 @nicholasbishop