Skip to content

Conditionally implement core::error::Error for all error types #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicholasbishop opened this issue Nov 27, 2022 · 2 comments
Closed

Conditionally implement core::error::Error for all error types #594

nicholasbishop opened this issue Nov 27, 2022 · 2 comments
Labels
enhancement help wanted

Comments

@nicholasbishop
Copy link
Member

In the same spirit as #587, we should implement the Error trait for all our other error types (e.g. these ones: https://docs.rs/uefi/latest/uefi/data_types/index.html#enums). This would be gated behind the unstable feature.
raccog added a commit to raccog/uefi-rs that referenced this issue Dec 18, 2022
@raccog
Implement Error and Display traits for FromStrError
51602d1 
For issue rust-osdev#594.
@raccog raccog mentioned this issue Dec 18, 2022
Merged
2 tasks
@phip1611
Copy link
Member

phip1611 commented Dec 19, 2022 •
edited
Loading

We should be able to remove the unstable feature in 2 months or so. Since Rust 1.65, the trait is part of libcore in stable Rust.

rust-lang/rust@bf7611d

Correction, this is in the core library but not yet stable.

@phip1611
Copy link
Member

phip1611 commented Mar 24, 2023 •
edited
Loading

The change needs to be done at least for:

  • unicode_collation::StrConversionError

@cmoylan cmoylan mentioned this issue Aug 10, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicholasbishop @phip1611