AML: Fix DefIfElse parser returning UnexpectedEndOfStream when If (...) {} is not followed by anything
#190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IsaacWoods
reviewed
Aug 28, 2023
| @@ -135,11 +143,11 @@ where | |||
| .map(move |then_branch| Ok((predicate_arg.as_bool()?, then_branch))) | |||
| }) | |||
| .then(choice!( | |||
There was a problem hiding this comment.
This is fine as the fix to this, but I wonder if a cleaner solution would be to replace the whole choice!(..., id().map(&[]) construct with a wrapper combinator (e.g. maybe) that would catch either a WrongParser or an UnexpectedEndOfStream? I think that would work
|
Interesting - now I see the problem, I'm kind of surprised we hadn't run into this sooner. Good catch though, and thanks for the PR! |
IsaacWoods
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes issue #188