Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

traits: Remove pattern in trait's method signature #238

Merged
merged 1 commit into from
Oct 24, 2016

Conversation

bluss
Copy link
Contributor

@bluss bluss commented Oct 24, 2016

This use of mut was nonsensical for now, but is proposed to be
disallowed by rustc in the future (as a bugfix).

See rust-lang/rust/pull/37378 for context.

This use of `mut` was nonsensical for now, but is proposed to be
disallowed by rustc in the future (as a bugfix in Rust).
@cuviper
Copy link
Member

cuviper commented Oct 24, 2016

OK, thanks!

@homu r+ 96e96ef

@homu homu merged commit 96e96ef into rust-num:master Oct 24, 2016
homu added a commit that referenced this pull request Oct 24, 2016
traits: Remove pattern in trait's method signature

This use of `mut` was nonsensical for now, but is proposed to be
disallowed by rustc in the future (as a bugfix).

See rust-lang/rust/pull/37378 for context.
@homu
Copy link
Contributor

homu commented Oct 24, 2016

⚡ Test exempted - status

@bluss bluss deleted the fix-mut branch October 24, 2016 23:29
remexre pushed a commit to remexre/num that referenced this pull request Jun 1, 2017
No tuple structs with private fields in public API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants