Conversation
5 tasks
notgull
approved these changes
Oct 7, 2023
This was referenced Oct 7, 2023
Closed
Member
Author
|
@kchibisov perhaps you also want to take a look at this PR in conjunction with rust-windowing/winit#3126? |
kchibisov
suggested changes
Oct 8, 2023
Contributor
kchibisov
left a comment
kchibisov
left a comment
There was a problem hiding this comment.
In winit we kept the raw-window-handle v0.4, which is missing here. It would be nice to have it as well?
notgull
approved these changes
Oct 8, 2023
Member
Author
|
@kchibisov we never had it so I don't really feel like it adds any value unless there are compelling reasons to? Perhaps to keep the implementations in |
Member
Author
|
In addition, what do folks think about having any of these features in the |
Contributor
|
@MarijnS95 yes, just for consistency reasons. But I don't care that much if it's fine with you.
Whatever you prefer as a library writer. You could suggest updating to 0.6.0 if you do breaking changes anyway. |
MarijnS95
changed the title
HasWindowHandle for 0.6 (and maintain 0.5)HasWindowHandle for 0.4 and 0.6 (and maintain 0.5)
Member
Author
|
@kchibisov added. I'll think about the default features for a bit... |
kchibisov
approved these changes
Oct 8, 2023
…aintain 0.5) Following [the same strategy in winit], move `raw-window-handle 0.5` behind a `rwh_05` feature and add `raw-window-handle 0.4` and the newly released `raw-window-handle 0.6` behind a corresponding `rwh04`/`rwh_06` feature. The new **non-raw** trait and **lifetimed** type since `0.6` have been implemented instead, as `raw-window-handle` provides blanket implementations to coerce/convert back to `Raw*` types. [the same strategy in winit]: rust-windowing/winit#3126
ThierryBerger
added a commit
to ThierryBerger/android-activity
that referenced
this pull request
Oct 25, 2023
The `ndk` crate enables `raw-window-handle 0.6` by default (because of rust-mobile/ndk#434 (comment)) which might not be used by consumers of the `android-activity` crate at all, or might (still) be a mismatching version. Even if the `rwh_0x` features are additive, figuring that out leads to cryptic errors and it is best to turn off these defaults completely and leave it to the user to turn it back on in their own `[dependencies]` section if desired.
MarijnS95
pushed a commit
to rust-mobile/android-activity
that referenced
this pull request
Oct 25, 2023
The `ndk` crate enables `raw-window-handle 0.6` by default (because of rust-mobile/ndk#434 (comment)) which might not be used by consumers of the `android-activity` crate at all, or might (still) be a mismatching version. Even if the `rwh_0x` features are additive, figuring that out leads to cryptic errors and it is best to turn off these defaults completely and leave it to the user to turn it back on in their own `[dependencies]` section if desired.
MarijnS95
added a commit
to rust-windowing/winit
that referenced
this pull request
Nov 3, 2023
We decided to add `rwh_06` to the `default` list of features in the `ndk` to [nudge users to upgrade], but this forces `winit` to always (transitively) include `raw-window-handle 0.6` even if the user has set a different `rwh_xx` feature on the `winit` crate. `winit` already forwards the respective `rwh_xx` feaure to the `ndk` crate anyway, so this default should just be turned off. At the time of writing this is the only `default` feature of the `ndk`. [nudge users to upgrade]: rust-mobile/ndk#434 (comment)
kchibisov
pushed a commit
to rust-windowing/winit
that referenced
this pull request
Nov 4, 2023
We decided to add `rwh_06` to the `default` list of features in the `ndk` to [nudge users to upgrade], but this forces `winit` to always (transitively) include `raw-window-handle 0.6` even if the user has set a different `rwh_xx` feature on the `winit` crate. `winit` already forwards the respective `rwh_xx` feaure to the `ndk` crate anyway, so this default should just be turned off. At the time of writing this is the only `default` feature of the `ndk`. Links: rust-mobile/ndk#434 (comment)
kchibisov
pushed a commit
to kchibisov/winit
that referenced
this pull request
Nov 24, 2023
We decided to add `rwh_06` to the `default` list of features in the `ndk` to [nudge users to upgrade], but this forces `winit` to always (transitively) include `raw-window-handle 0.6` even if the user has set a different `rwh_xx` feature on the `winit` crate. `winit` already forwards the respective `rwh_xx` feaure to the `ndk` crate anyway, so this default should just be turned off. At the time of writing this is the only `default` feature of the `ndk`. Links: rust-mobile/ndk#434 (comment)
kchibisov
pushed a commit
to rust-windowing/winit
that referenced
this pull request
Nov 24, 2023
We decided to add `rwh_06` to the `default` list of features in the `ndk` to [nudge users to upgrade], but this forces `winit` to always (transitively) include `raw-window-handle 0.6` even if the user has set a different `rwh_xx` feature on the `winit` crate. `winit` already forwards the respective `rwh_xx` feaure to the `ndk` crate anyway, so this default should just be turned off. At the time of writing this is the only `default` feature of the `ndk`. Links: rust-mobile/ndk#434 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the same strategy in winit, move
raw-window-handle 0.5behind arwh_05feature and addraw-window-handle 0.4and the newly releasedraw-window-handle 0.6behind a correspondingrwh04/rwh_06feature. The new non-raw trait and lifetimed type since0.6have been implemented instead, asraw-window-handleprovides blanket implementations to coerce/convert back toRaw*types.