Unrolled build for rust-lang#129824

rust-timer · web-flow · commit 75ab755dc281 · 2024-08-31T19:25:40.000-04:00
Rollup merge of rust-lang#129824 - GuillaumeGomez:code-example-buttons-mobile, r=notriddle Fix code examples buttons not appearing on click on mobile When browsing docs on mobile today, I realized that the buttons didn't appear when I tapped on the code example. One issue: I have no idea how to add a regression test for this case... r? ``@notriddle``
diff --git a/src/librustdoc/html/static/js/main.js b/src/librustdoc/html/static/js/main.js
@@ -1878,9 +1878,15 @@ href="https://doc.rust-lang.org/${channel}/rustdoc/read-documentation/search.htm
         if (elem === null) {
             return;
         }
-        const buttons = elem.querySelector(".button-holder");
+        let buttons = elem.querySelector(".button-holder");
         if (buttons === null) {
-            return;
+            // On mobile, you can't hover an element so buttons need to be created on click
+            // if they're not already there.
+            addCopyButton(event);
+            buttons = elem.querySelector(".button-holder");
+            if (buttons === null) {
+                return;
+            }
         }
         buttons.classList.toggle("keep-visible");
     }

Original file line number	Diff line number	Diff line change
`@@ -1878,9 +1878,15 @@ href="https://doc.rust-lang.org/${channel}/rustdoc/read-documentation/search.htm`
`1878`	`1878`	`if (elem === null) {`
`1879`	`1879`	`return;`
`1880`	`1880`	`}`
`1881`		`- const buttons = elem.querySelector(".button-holder");`
	`1881`	`+ let buttons = elem.querySelector(".button-holder");`
`1882`	`1882`	`if (buttons === null) {`
`1883`		`- return;`
	`1883`	`+ // On mobile, you can't hover an element so buttons need to be created on click`
	`1884`	`+ // if they're not already there.`
	`1885`	`+ addCopyButton(event);`
	`1886`	`+ buttons = elem.querySelector(".button-holder");`
	`1887`	`+ if (buttons === null) {`
	`1888`	`+ return;`
	`1889`	`+ }`
`1884`	`1890`	`}`
`1885`	`1891`	`buttons.classList.toggle("keep-visible");`
`1886`	`1892`	`}`