Skip to content

Commit 23e040a

Browse files
committed
Auto merge of rust-lang#125426 - jieyouxu:rmake-support-env-reset, r=saethlin
Update `compiler-builtins` test to not clear essential env vars Noticed in rust-lang#122580 (comment), the `compiler-builtins` test failed on Windows for a `cargo` invocation because necessary env vars `TMP` and `TEMP` were cleared by `Command::env_clear`, causing temp dir eventually used by codegen to fallback to the Windows directory, which will trigger permission errors. This PR removes the `env_clear` on the cargo invocation. r? `@saethlin` (feel free to reroll, since you authored the test) try-job: x86_64-msvc try-job: test-various
2 parents 44701e0 + 2949195 commit 23e040a

File tree

1 file changed

+0
-1
lines changed
  • tests/run-make/compiler-builtins

1 file changed

+0
-1
lines changed

tests/run-make/compiler-builtins/rmake.rs

-1
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ fn main() {
5656
"--target",
5757
&target,
5858
])
59-
.env_clear()
6059
.env("PATH", path)
6160
.env("RUSTC", rustc)
6261
.env("RUSTFLAGS", "-Copt-level=0 -Cdebug-assertions=yes")

0 commit comments

Comments
 (0)