Skip to content

Added the recv_tos socket option#299

Merged
Thomasdezeeuw merged 5 commits intorust-lang:masterfrom
voysys-archive:master
Apr 26, 2022
Merged

Added the recv_tos socket option#299
Thomasdezeeuw merged 5 commits intorust-lang:masterfrom
voysys-archive:master

Conversation

@JoNil
Copy link
Contributor

@JoNil JoNil commented Apr 22, 2022

No description provided.

Thomasdezeeuw
Thomasdezeeuw requested changes Apr 22, 2022
View reviewed changes
Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition sounds good, but this needs tests and Windows support (see https://docs.microsoft.com/en-us/windows/win32/winsock/ipproto-ip-socket-options).

@JoNil
Copy link
Contributor Author

JoNil commented Apr 25, 2022

I didn't find the IP_RECVTOS symbol in winapi-rs. Does anyone know if it is supported there and is just not exposed?

@Thomasdezeeuw
Copy link
Collaborator

Thomasdezeeuw commented Apr 25, 2022

I didn't find the IP_RECVTOS symbol in winapi-rs. Does anyone know if it is supported there and is just not exposed?

I can't find it either. Perhaps we should move to windows_sys (it has it: https://docs.rs/windows-sys/latest/windows_sys/Win32/Networking/WinSock/constant.IP_RECVTOS.html), but that's a larger topic. For now you can remove Window support and we'll open issue to add it later.

@JoNil
Copy link
Contributor Author

JoNil commented Apr 25, 2022

In the last commit i added windows the the cfg so that it is not included :)

@Thomasdezeeuw Thomasdezeeuw merged commit 040769b into rust-lang:master Apr 26, 2022
@Thomasdezeeuw
Copy link
Collaborator

Thomasdezeeuw commented Apr 26, 2022

Thanks @JoNil.

@Thomasdezeeuw Thomasdezeeuw mentioned this pull request Apr 26, 2022
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Thomasdezeeuw Thomasdezeeuw Thomasdezeeuw approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoNil @Thomasdezeeuw