fix!(config): re-enable active toolchain installation in Cfg::find_active_toolchain() with optional opt-out
#4214
+124
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisDenton
reviewed
Mar 4, 2025
rami3l
force-pushed
the
fix/bandaid
branch
2 times, most recently
from
81de518 to
fc6d18e
Compare
ChrisDenton
approved these changes
Mar 4, 2025
…ctive_toolchain()` with optional opt-out
|
I've split this into two commits to make it a little easier to review, and have made some stylistic tweaks. LGTM! |
djc
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Following @djc's previous statement at #4211 (comment), I sincerely apologize for all the previous issues related to the abrupt breaking change without enough clarity and transparency, and, if a well-organized public discussion allows this change to happen, a potential experimental stage with a properly-extended migration period.
This PR tries to mitigate #4211 by introducing a new environment variable
RUSTUP_AUTO_INSTALLthat defaults to1and is subsumed under. This environment variable, when evaluated toCItrue, will try to install the active toolchain inCfg::find_active_toolchain().@rust-lang/rustup please feel free to change this PR as you see fit so that we can land the fix as promptly as possible.
Concerns
Remaining work around this PR might include: