Fixed 'Comment removed between type name and =' issue #4448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
calebcartwright
left a comment
calebcartwright
left a comment
There was a problem hiding this comment.
Thanks @whizsid! This is a good starting point but we'll need to iterate on it a bit to cover other scenarios. Inline feedback left for your review
Contributor
Author
|
@calebcartwright Thank you for the revision. I changed my PR as you suggested. Can you kindly review it again? |
Comment on lines
+1664
to
+1671
| combine_strs_with_missing_comments( | ||
| context, | ||
| result.trim_end(), | ||
| "=", | ||
| comment_span, | ||
| comment_shape, | ||
| true, | ||
| )? |
Member
There was a problem hiding this comment.
We will want to use the comment_shape here for comments, but in cases where there's a where clause we don't want to for the assignment operator and the rhs. That's because in cases where the item has a where clause followed by a block or assignment the block/assignment is not supposed to be indented.
Member
|
Thank you! |
calebcartwright
pushed a commit
to calebcartwright/rustfmt
that referenced
this pull request
Nov 29, 2020
* Fixed Comment removed between type name and = issue * Fixed where clause issue and pass the full span * has_where condition inline * Fixed indentation error on where clause * Removed tmp file
calebcartwright
pushed a commit
that referenced
this pull request
Nov 29, 2020
* Fixed Comment removed between type name and = issue * Fixed where clause issue and pass the full span * has_where condition inline * Fixed indentation error on where clause * Removed tmp file
Contributor
|
Backported in #4564 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4244 .