-
Notifications
You must be signed in to change notification settings - Fork 1k
Anchor for version config option broken on config site #4665
Copy link
Copy link
Closed
Labels
1x-backport:pendingFixed/resolved in source but not yet backported to a 1x branch and releaseFixed/resolved in source but not yet backported to a 1x branch and releaseA-configArea: configurationArea: configurationE-help-wantedCall for participation: help is requested to fix this issueCall for participation: help is requested to fix this issuegood first issueIssues up for grabs, also good candidates for new rustfmt contributorsIssues up for grabs, also good candidates for new rustfmt contributors
Metadata
Metadata
Assignees
Labels
1x-backport:pendingFixed/resolved in source but not yet backported to a 1x branch and releaseFixed/resolved in source but not yet backported to a 1x branch and releaseA-configArea: configurationArea: configurationE-help-wantedCall for participation: help is requested to fix this issueCall for participation: help is requested to fix this issuegood first issueIssues up for grabs, also good candidates for new rustfmt contributorsIssues up for grabs, also good candidates for new rustfmt contributors
Type
Fields
Give feedbackNo fields configured for issues without a type.
The config documentation website supports anchors for the config options to support directly linking to an option, e.g. https://rust-lang.github.io/rustfmt/?version=v1.4.32&search=#trailing_comma as well as a query parameter,
?versionthat supports specifying the version of the config documentation to show (more info on config versioning in #4664).However, there is also a config option named
versionbut the anchor for this option does not work, presumably due to the conflictingversionusages and how we're handling query parameters. Not sure what the best fix is, but would be good to be able to fix the anchor, even if that means changing how we deal with query params (including potentially renaming params if needed)https://github.com/rust-lang/rustfmt/blob/v1.4.32/Configurations.md#version
(can also be found directly above https://rust-lang.github.io/rustfmt/?version=v1.4.32&search=#where_single_line)