Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong results in some FMA cases #11

Open
RalfJung opened this issue Sep 29, 2023 · 3 comments · May be fixed by #21
Open

Wrong results in some FMA cases #11

RalfJung opened this issue Sep 29, 2023 · 3 comments · May be fixed by #21

Comments

@RalfJung
Copy link
Member

Due to this being an exact port of the LLVM library, this crate is affected by llvm/llvm-project#63895: some FMA produce wrong results. This seems worth tracking on our side as well, if only to make it easier to find, given that "produces wrong result" is the worst kind of bug.
@RalfJung RalfJung mentioned this issue Jul 28, 2023
Open
@RalfJung RalfJung mentioned this issue Jan 5, 2024
Merged
@beetrees
Copy link

I've posted a PR to fix this in LLVM at llvm/llvm-project#98721. I've also made a Rust port of the fix at https://github.com/beetrees/rustc_apfloat/tree/fix-mul-add.

@RalfJung
Copy link
Member Author

llvm/llvm-project#63895 has been fixed upstream. Can we get that fix into the Rust port as well? :) Cc @eddyb @wesleywiser

@RalfJung
Copy link
Member Author

@beetrees could you make a PR for your branch?

@beetrees beetrees linked a pull request Mar 10, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sig::add_or_sub and IeeeFloat::normalize beetrees/rustc_apfloat
2 participants
@RalfJung @beetrees