Skip to content

Commit 892c681

Browse files
Mark-SimulacrumMark-Simulacrum
authored
Merge pull request #1912 from Mark-Simulacrum/triage
Add triage for this week
2 parents cc81f96 + 1c99bc4 commit 892c681

File tree

1 file changed

+153
-0
lines changed

1 file changed

+153
-0
lines changed

‎triage/2024-05-27.md

+153
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,153 @@
1+
# 2024-05-27 Triage Log
2+
3+
A relatively quiet week, with few large changes, the largest driven by further
4+
increasing the scope of unsafe precondition checking.
5+
6+
Triage done by **@simulacrum**.
7+
Revision range: [1d0e4afd..a59072ec](https://perf.rust-lang.org/?start=1d0e4afd4cac09078e12a232508c3e9f8d42535d&end=a59072ec4fb6824213df5e9de8cae4812fd4fe97&absolute=false&stat=instructions%3Au)
8+
9+
**Summary**:
10+
11+
| (instructions:u) | mean | range | count |
12+
|:----------------------------------:|:-----:|:--------------:|:-----:|
13+
| Regressions ❌ <br /> (primary) | 1.6% | [0.2%, 6.3%] | 84 |
14+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.1%, 3.8%] | 66 |
15+
| Improvements ✅ <br /> (primary) | -0.4% | [-2.3%, -0.2%] | 37 |
16+
| Improvements ✅ <br /> (secondary) | -1.7% | [-3.8%, -0.2%] | 22 |
17+
| All ❌✅ (primary) | 1.0% | [-2.3%, 6.3%] | 121 |
18+
19+
2 Regressions, 3 Improvements, 5 Mixed; 3 of them in rollups
20+
51 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rewrite native thread-local storage [#116123](https://github.com/rust-lang/rust/pull/116123) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ed172dbbaf1c702b99da54554b33b3fe65021da9&end=9c8a58fdb895204cb19eeb97472a78caa1c57c19&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 1.2%] | 10 |
29+
| Regressions ❌ <br /> (secondary) | 1.0% | [0.7%, 1.6%] | 9 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.4% | [0.2%, 1.2%] | 10 |
33+
34+
Regressions deemed worth the overall change's contents (see
35+
https://github.com/rust-lang/rust/pull/116123#issuecomment-2009408868). The TLS
36+
state is now stored in a single thread-local object rather than two, which
37+
should decrease costs of addressing it in general (modulo LLVM difficulties).
38+
39+
Rollup of 6 pull requests [#125463](https://github.com/rust-lang/rust/pull/125463) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=78dd504f2fd87c0cfabff7d9174253411caf2f80&end=7601adcc764d42c9f2984082b49948af652df986&stat=instructions:u)
40+
41+
| (instructions:u) | mean | range | count |
42+
|:----------------------------------:|:-----:|:--------------:|:-----:|
43+
| Regressions ❌ <br /> (primary) | 1.4% | [1.1%, 2.0%] | 8 |
44+
| Regressions ❌ <br /> (secondary) | 1.0% | [0.4%, 1.8%] | 23 |
45+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.5%, -0.5%] | 1 |
46+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
47+
| All ❌✅ (primary) | 1.2% | [-0.5%, 2.0%] | 9 |
48+
49+
Likely related to fixing an issue around LLD discovery, see
50+
https://github.com/rust-lang/rust/pull/125463#issuecomment-2129069901. Bugfix
51+
warrants spending a bit more time.
52+
53+
#### Improvements
54+
55+
Move the checks for Arguments constructors to inline const [#125518](https://github.com/rust-lang/rust/pull/125518) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0a59f113629aafb6e5ee55ad04a2d451a11d8466&end=75e2c5dcd0ddce0fe0eb3d4a2195cd51073c729b&stat=instructions:u)
56+
57+
| (instructions:u) | mean | range | count |
58+
|:----------------------------------:|:-----:|:--------------:|:-----:|
59+
| Regressions ❌ <br /> (primary) | - | - | 0 |
60+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
61+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.7%, -0.3%] | 5 |
62+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.9%, -0.4%] | 7 |
63+
| All ❌✅ (primary) | -0.5% | [-0.7%, -0.3%] | 5 |
64+
65+
66+
Remove `DefId` from `EarlyParamRegion` [#125468](https://github.com/rust-lang/rust/pull/125468) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cdc509f7c09361466d543fc8311ce7066b10cc4f&end=fec98b3bbc94b54a0b3085d004708aabcc48081a&stat=instructions:u)
67+
68+
| (instructions:u) | mean | range | count |
69+
|:----------------------------------:|:-----:|:--------------:|:-----:|
70+
| Regressions ❌ <br /> (primary) | - | - | 0 |
71+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
72+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.9%, -0.2%] | 48 |
73+
| Improvements ✅ <br /> (secondary) | -0.8% | [-2.0%, -0.3%] | 19 |
74+
| All ❌✅ (primary) | -0.4% | [-0.9%, -0.2%] | 48 |
75+
76+
77+
[perf] Delay the construction of early lint diag structs [#125410](https://github.com/rust-lang/rust/pull/125410) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fec98b3bbc94b54a0b3085d004708aabcc48081a&end=b582f807fae230b22ac126ff1d8a13262bb099ba&stat=instructions:u)
78+
79+
| (instructions:u) | mean | range | count |
80+
|:----------------------------------:|:-----:|:--------------:|:-----:|
81+
| Regressions ❌ <br /> (primary) | - | - | 0 |
82+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
83+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.7%, -0.3%] | 12 |
84+
| Improvements ✅ <br /> (secondary) | -2.0% | [-2.8%, -1.2%] | 13 |
85+
| All ❌✅ (primary) | -0.5% | [-0.7%, -0.3%] | 12 |
86+
87+
88+
#### Mixed
89+
90+
Follow-up fixes to `report_return_mismatched_types` [#123812](https://github.com/rust-lang/rust/pull/123812) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1d0e4afd4cac09078e12a232508c3e9f8d42535d&end=e8753914580fb42554a79a4b5c5fb4cc98933231&stat=instructions:u)
91+
92+
| (instructions:u) | mean | range | count |
93+
|:----------------------------------:|:-----:|:--------------:|:-----:|
94+
| Regressions ❌ <br /> (primary) | 1.1% | [0.6%, 1.8%] | 3 |
95+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.1%, 0.2%] | 6 |
96+
| Improvements ✅ <br /> (primary) | - | - | 0 |
97+
| Improvements ✅ <br /> (secondary) | -1.1% | [-1.1%, -1.1%] | 2 |
98+
| All ❌✅ (primary) | 1.1% | [0.6%, 1.8%] | 3 |
99+
100+
Seems to be limited primarily to one scenario in regex, with lots of new
101+
metadata decoding. Asked for follow-up by PR author.
102+
103+
Make early lints translatable [#124417](https://github.com/rust-lang/rust/pull/124417) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=39e02f1bd1e53d009da382654139f7c0639172a8&end=791adf759cc065316f054961875052d5bc03e16c&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | 1.5% | [0.2%, 6.3%] | 66 |
108+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.5%] | 7 |
109+
| Improvements ✅ <br /> (primary) | - | - | 0 |
110+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.1%, -0.6%] | 12 |
111+
| All ❌✅ (primary) | 1.5% | [0.2%, 6.3%] | 66 |
112+
113+
Regressions are partially mitigated by #125410 (see earlier in the report).
114+
Further follow-up is expected to investigate closing remaining gap
115+
(https://github.com/rust-lang/rust/pull/124417#issuecomment-2126056523).
116+
117+
Panic directly in Arguments::new* instead of recursing [#117804](https://github.com/rust-lang/rust/pull/117804) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9c8a58fdb895204cb19eeb97472a78caa1c57c19&end=606afbb617a2949a4e35c4b0258ff94c980b9451&stat=instructions:u)
118+
119+
| (instructions:u) | mean | range | count |
120+
|:----------------------------------:|:-----:|:--------------:|:-----:|
121+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 2 |
122+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 0.9%] | 9 |
123+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.5%, -0.5%] | 1 |
124+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
125+
| All ❌✅ (primary) | 0.0% | [-0.5%, 0.3%] | 3 |
126+
127+
Regressions are likely to be inliner noise, not meaningful changes.
128+
129+
Rollup of 7 pull requests [#125456](https://github.com/rust-lang/rust/pull/125456) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=606afbb617a2949a4e35c4b0258ff94c980b9451&end=5baee04b6349d176440cb1fcd5424a89f67b9f7b&stat=instructions:u)
130+
131+
| (instructions:u) | mean | range | count |
132+
|:----------------------------------:|:-----:|:--------------:|:-----:|
133+
| Regressions ❌ <br /> (primary) | - | - | 0 |
134+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 8 |
135+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.3%] | 2 |
136+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.9%, -0.4%] | 7 |
137+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.3%] | 2 |
138+
139+
Seems plausible that the regression is due to #124389 (since it affected derive
140+
macros). But also seems not worth further investigation given it's a secondary
141+
benchmark and minimal impact. Marked as triaged.
142+
143+
Add assert_unsafe_precondition to unchecked_{add,sub,neg,mul,shl,shr} methods [#121571](https://github.com/rust-lang/rust/pull/121571) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=14562ddf8c4302a52c72c9c71f5be6516fec5537&end=48f00110d0dae38b3046a9ac05d20ea321fd6637&stat=instructions:u)
144+
145+
| (instructions:u) | mean | range | count |
146+
|:----------------------------------:|:-----:|:--------------:|:-----:|
147+
| Regressions ❌ <br /> (primary) | 1.5% | [0.2%, 3.4%] | 27 |
148+
| Regressions ❌ <br /> (secondary) | 1.8% | [0.4%, 3.8%] | 5 |
149+
| Improvements ✅ <br /> (primary) | -0.9% | [-2.5%, -0.3%] | 5 |
150+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
151+
| All ❌✅ (primary) | 1.1% | [-2.5%, 3.4%] | 32 |
152+
153+
Regressions are likely expected as we're lowering more code that's late-removed.

0 commit comments

Comments
 (0)