add tool to check semantic line breaks#1485
Conversation
|
I don't have an objection to enforcing sembr but the implementation does look fragile, e.g. there's no tokenizer. Have you considered using an existing tool like https://github.com/bobheadxi/readable? |
|
I have not... thanks for the suggestion, will have a look. |
|
I have tried using |
|
This tool of mine handles both issues without choking. I intend to get back to making it more fancy... I keep postponing. |
|
Sorry, due to me messing up a git operation, we sadly had to force-push the whole commit history of rustc-dev-guide :( If you'd like to update this pull request, you will have to rebase it in a special way onto the new commit history (the new More context can be found here. |
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
|
I don't know how to do tokenization, but I attached a sample chapter to show output from the tool |
|
Thanks for the PR. If you have write access, feel free to merge this PR if it does not need reviews. You can request a review using |
See #1132
Run it so:
Diff is large, so maybe should be automated.