Add lint explicit_auto_deref take 2
#8355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @flip1995 (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
|
☔ The latest upstream changes (presumably #8359) made this pull request unmergeable. Please resolve the merge conflicts. |
Jarcho
force-pushed
the
explicit_auto_deref_2
branch
14 times, most recently
from
ba3112f to
a31eaad
Compare
Contributor
|
☔ The latest upstream changes (presumably #8289) made this pull request unmergeable. Please resolve the merge conflicts. |
Herschel
added a commit
to Herschel/ruffle
that referenced
this pull request
Jan 29, 2022
Currently it is not directly possible to configure lints for the entire workspace via TOML, which forced us to repeat `#![allow]` blocks in each crate. embark pointed out this workaround to configure lints at the workspace level via RUSTFLAGS: EmbarkStudios/rust-ecosystem#22 (comment) Remove the common `#![allow]` blocks and switch to this method for global lint config. Temporarily allow `needless_borrow` lint, buggy pending this fix: rust-lang/rust-clippy#8355
Herschel
added a commit
to ruffle-rs/ruffle
that referenced
this pull request
Jan 29, 2022
Currently it is not directly possible to configure lints for the entire workspace via TOML, which forced us to repeat `#![allow]` blocks in each crate. embark pointed out this workaround to configure lints at the workspace level via RUSTFLAGS: EmbarkStudios/rust-ecosystem#22 (comment) Remove the common `#![allow]` blocks and switch to this method for global lint config. Temporarily allow `needless_borrow` lint, buggy pending this fix: rust-lang/rust-clippy#8355
Jarcho
force-pushed
the
explicit_auto_deref_2
branch
3 times, most recently
from
3d37661 to
5a6a6d6
Compare
Contributor
|
Does this also fix this case? pub fn put_u16(v: u16, out: &mut [u8]) {
let out: &mut [u8; 2] = (&mut out[..2]).try_into().unwrap();
*out = u16::to_be_bytes(v);
}Warning: --> rustls/src/msgs/codec.rs:91:29
|
91 | let out: &mut [u8; 2] = (&mut out[..2]).try_into().unwrap();
| ^^^^^^^^^^^^^^^ help: change this to: `out[..2]`
|
= note: `#[warn(clippy::needless_borrow)]` on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow |
Contributor
|
☔ The latest upstream changes (presumably #9007) made this pull request unmergeable. Please resolve the merge conflicts. |
Jarcho
force-pushed
the
explicit_auto_deref_2
branch
from
1d935dd to
dd3d747
Compare
Contributor
|
☔ The latest upstream changes (presumably #8639) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Oh no, another instance, where GitHub didn't show me a notification for a force push. @Jarcho please approve this PR yourself with |
`needless_borrow` will now walk further to find the target type.
Merge `Position` and `AutoDerefStability`
Jarcho
force-pushed
the
explicit_auto_deref_2
branch
from
dd3d747 to
68596aa
Compare
Jarcho
force-pushed
the
explicit_auto_deref_2
branch
from
68596aa to
5e2a2d3
Compare
Contributor
Author
|
@bors r=flip1995 |
Contributor
|
📌 Commit 5e2a2d3 has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
relrelb
added a commit
to relrelb/ruffle
that referenced
this pull request
Jul 8, 2022
Though rust-lang/rust-clippy#8355 has been merged, it seems to still report false-positives on nightly channel. For now just fix the instances reported by stable clippy, and keep `needless_borrow` allowed.
relrelb
added a commit
to ruffle-rs/ruffle
that referenced
this pull request
Jul 8, 2022
Though rust-lang/rust-clippy#8355 has been merged, it seems to still report false-positives on nightly channel. For now just fix the instances reported by stable clippy, and keep `needless_borrow` allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #234
fixes: #8367
fixes: #8380
Still things to do:
This currently only lints&*<expr>when it doesn't triggerneedless_borrow.This requires a borrow after a deref to trigger. So*<expr>changing&&Tto&Twon't be caught.derefandderef_muttrait methods aren't linted.field accesses, nor method receivers are linted.This probably shouldn't lint reborrowing.&vec[..]when just&vecwould dochangelog: new lint
explicit_auto_deref