Fix question_mark FP on custom error type
#7860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @giraffate (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
dswij
commented
Oct 22, 2021
Comment on lines
160
to
166
| let _ = if let Ok(x) = func_returning_result() { | ||
| x | ||
| } else { | ||
| return Err("some error".to_string()); | ||
| }; | ||
|
|
||
| if func_returning_result().is_err() { | ||
| return func_returning_result(); | ||
| } |
Contributor
|
Sorry for the late reviewing. I can go back to reviewing in a few days. |
giraffate
reviewed
Oct 26, 2021
Contributor
giraffate
left a comment
giraffate
left a comment
There was a problem hiding this comment.
Overall looks good, thanks!
I made small comments. I prefer to use expr instead of expression for naming, if there is no specific reason.
dswij
force-pushed
the
question-mark-fp
branch
from
a6bbbb9 to
fb0fbad
Compare
Member
Author
|
Thanks for the review! Addressed the nits 🙂 |
giraffate
approved these changes
Oct 26, 2021
Contributor
|
@bors r+ Thanks! |
Contributor
|
📌 Commit fb0fbad has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7859
#7840 aims to ignore
question_markwhen the return type is custom, which is covered here. But this fails when there is a call in conditional predicatechangelog: [
question_mark] Fix false positive when there is call in conditional predicate