Expand box_vec lint to box_collection #7693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Contributor
Author
|
@flip1995 it seems that |
Manishearth
requested changes
Sep 20, 2021
Manishearth
approved these changes
Sep 22, 2021
Member
|
@F3real you don't have to remove mentions, you just need to make sure the |
Manishearth
approved these changes
Sep 22, 2021
Member
|
@bors r+ |
Contributor
|
📌 Commit bb971e0 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Sep 22, 2021
Expand box_vec lint to box_collection fixed #7451 changelog: Report unnecessary boxing for collections
Contributor
|
💔 Test failed - checks-action_test |
Member
|
@bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #7451
changelog: Expand
box_vecinto [box_collection], and have it error on all sorts of boxed collections