Skip to content

Don't warn about cfg!(..) as a constant in assertions#7319

Merged
bors merged 2 commits into
rust-lang:masterfrom
m-ou-se:cfg-not-const
Jun 4, 2021
Merged

Don't warn about cfg!(..) as a constant in assertions#7319
bors merged 2 commits into
rust-lang:masterfrom
m-ou-se:cfg-not-const

Conversation

@m-ou-se

@m-ou-se m-ou-se commented Jun 4, 2021

Copy link
Copy Markdown
Member

This makes clippy understand that cfg!(..) is not just a hardcoded true or false (even though it expands to one of those).

cc @khyperia

changelog: Don't treat cfg!(..) as a constant in [assertions-on-constants]

@rust-highfive

Copy link
Copy Markdown

r? @camsteffen

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 4, 2021
@camsteffen

Copy link
Copy Markdown
Contributor

Thanks!

@bors r+

@bors

bors commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

📌 Commit 38ab1a6 has been approved by camsteffen

@bors

bors commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

⌛ Testing commit 38ab1a6 with merge b1752f6...

@bors

bors commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: camsteffen
Pushing b1752f6 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants