Adding the ability to invalidate caches to force metadata collection #7256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
23 tasks
flip1995
requested changes
May 20, 2021
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
I'm good with adding filetime, since it's just another crate by Alex.
flip1995
approved these changes
May 25, 2021
Member
|
@bors r+ Thanks! |
Contributor
|
📌 Commit e3a1ae7 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
May 25, 2021
…on, r=flip1995 Adding the ability to invalidate caches to force metadata collection This adds the discussed hack to touch `clippy_lints/src/lib.rs` to invalidate cargos cache and force metadata collection. I've decided to use the [`filetime`](https://github.com/alexcrichton/filetime) crate instead of the touch command to make is cross-platform and just cleaner in general. Looking at the maintainers I would say that it's a save crate to use xD. --- cc: #7172 I know this ID without looking it up now... This is not good changelog: none r? `@flip1995`
Contributor
|
💥 Test timed out |
Member
|
@bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the discussed hack to touch
clippy_lints/src/lib.rsto invalidate cargos cache and force metadata collection. I've decided to use thefiletimecrate instead of the touch command to make is cross-platform and just cleaner in general. Looking at the maintainers I would say that it's a save crate to use xD.cc: #7172 I know this ID without looking it up now... This is not good
changelog: none
r? @flip1995