New lint match_vec_item
#5522
Merged
New lint match_vec_item
#5522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
requested changes
Apr 24, 2020
flip1995
added
the
S-waiting-on-author
Contributor
Author
|
I have updated the code according to your suggestions. And thanks for reviewing 😃 |
phansch
reviewed
Apr 25, 2020
flip1995
reviewed
Apr 25, 2020
Member
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
LGTM overall. Some minor comments.
- Changed lint category to `correctness` - Moved main function to bottom in test file - Added `FIXME` comment to `span_lint_and_sugg` to improve later
flip1995
approved these changes
Apr 26, 2020
Member
|
|
Contributor
Author
Yep, forgot about this |
Contributor
|
@bors r+ |
Contributor
|
📌 Commit b574941 has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Apr 27, 2020
New lint `match_vec_item` Added new lint to warn a match on index item which can panic. It's always better to use `get(..)` instead. Closes #5500 changelog: New lint `match_on_vec_items`
Contributor
|
💔 Test failed - checks-action_test |
Contributor
|
@bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new lint to warn a match on index item which can panic. It's always better to use
get(..)instead.Closes #5500
changelog: New lint
match_on_vec_items