Fix breakage due to rust-lang/rust#61988 #4258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Jul 6, 2019
Member
Manishearth
left a comment
Manishearth
left a comment
There was a problem hiding this comment.
r=me with desugaring in utils
clippy_lints/src/loops.rs
Outdated
| if let ExprKind::Loop(block, _, LoopSource::While) = &expr.node; | ||
| if let Block { expr: Some(expr), .. } = &**block; | ||
| if let ExprKind::Match(cond, arms, MatchSource::WhileDesugar) = &expr.node; | ||
| if let ExprKind::DropTemps(cond) = &cond.node; |
Member
There was a problem hiding this comment.
This should be a while_desugar in utils like the if_let_desugar and for_desugar we already have
tesuji
reviewed
Jul 6, 2019
clippy_lints/src/loops.rs
Outdated
| }, | ||
| NeverLoopResult::MayContinueMainLoop | NeverLoopResult::Otherwise => (), | ||
| } | ||
| }; |
tesuji
reviewed
Jul 6, 2019
clippy_lints/src/utils/author.rs
Outdated
| match des { | ||
| hir::LoopSource::ForLoop => "LoopSource::ForLoop", | ||
| hir::LoopSource::Loop => "LoopSource::Loop", | ||
| hir::LoopSource::While => "LoopSource::WhileDesugar", |
Member
|
@bors r+ thanks! |
Contributor
|
📌 Commit adcc02e has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jul 6, 2019
Fix breakage due to rust-lang/rust#61988 changelog: none
Contributor
|
@Manishearth reapprove? |
Member
|
@bors r+ |
Contributor
|
📌 Commit c72be0f has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jul 7, 2019
Fix breakage due to rust-lang/rust#61988 changelog: none
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: none