Avoid map_unwrap_or fix when default is adjusted#16928
Open
cyphercodes wants to merge 1 commit intorust-lang:masterfrom
Open
Avoid map_unwrap_or fix when default is adjusted#16928cyphercodes wants to merge 1 commit intorust-lang:masterfrom
cyphercodes wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16901
Suppress the machine-applicable
map_orsuggestion formap_unwrap_orwhen theunwrap_ordefault expression was type-adjusted by the original call. In those cases, moving the default intomap_orcan make inference use the unadjusted type and reject the closure return type. The lint still fires, but without an autofix.Added a regression for the reported
split_once(...).map(|(_, v)| v).unwrap_or(&raw)case.Verification:
TESTNAME=map_unwrap_or cargo uitestcargo fmt --checkgit diff --checkchangelog: [
map_unwrap_or]: avoid suggestingmap_orwhen theunwrap_ordefault requires a type adjustment