Update itertools to 0.15#16805
Conversation
rustbot
added
the
S-waiting-on-review
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
jakubadamw
force-pushed
the
update-itertools
branch
from
2f61402 to
128a0bd
Compare
This comment has been minimized.
This comment has been minimized.
|
The compiler itself is on |
This comment has been minimized.
This comment has been minimized.
jakubadamw
force-pushed
the
update-itertools
branch
from
128a0bd to
81fb07c
Compare
This comment has been minimized.
This comment has been minimized.
Sure, fair enough. There’s a new version 0.15 coming up, so I figured I would open a PR in rust-lang/rust to bump the version in the compiler. The version hasn’t been published in crates.io just yet, so it remains a draft. I also updated this PR to cover 0.15 as well. |
|
Ping @jakubadamw since |
@Jarcho, thanks for the ping, I’ll update my PRs this evening. 🙂 |
jakubadamw
force-pushed
the
update-itertools
branch
from
81fb07c to
9e2be9d
Compare
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
…5, r=Mark-Simulacrum Update itertools to 0.15 This bumps the itertools dependency to [0.15](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md#0150). There’s a breaking change upstream in the shape of `itertools::Position`, so this updates the use sites of it as well, aside from submodules like clippy, which will be handled [separately](rust-lang/rust-clippy#16805).
…imulacrum Update itertools to 0.15 This bumps the itertools dependency to [0.15](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md#0150). There’s a breaking change upstream in the shape of `itertools::Position`, so this updates the use sites of it as well, aside from submodules like clippy, which will be handled [separately](rust-lang/rust-clippy#16805).
Rollup merge of #156419 - jakubadamw:update-itertools-to-0.15, r=Mark-Simulacrum Update itertools to 0.15 This bumps the itertools dependency to [0.15](https://github.com/rust-itertools/itertools/blob/master/CHANGELOG.md#0150). There’s a breaking change upstream in the shape of `itertools::Position`, so this updates the use sites of it as well, aside from submodules like clippy, which will be handled [separately](rust-lang/rust-clippy#16805).
|
@Jarcho, the itertools 0.15 update PR in rust-lang/rust has been merged, so could we perhaps go ahead with this so that the next sync of clippy in rust-lang/rust includes the update? Thank you! |
|
The analogous update in rust-lang/rust-analyzer#22685 landed in master, so that leaves us with Clippy and stdarch (which I’m yet to open a PR for) keeping rust’s Cargo.lock with an older version of itertools among the transitive dependencies. |
rustbot
removed
the
S-waiting-on-review
3 participants
Updates itertools to 0.15 and fixes a warning by moving from
group_by()tochunk_by().changelog: none