feat(explicit_deref_methods): don't lint in impl Deref(Mut)#16113
feat(explicit_deref_methods): don't lint in impl Deref(Mut)#16113samueltardieu merged 1 commit intorust-lang:masterfrom
impl Deref(Mut)#16113Conversation
rustbot
added
the
S-waiting-on-review
|
rustbot has assigned @samueltardieu. Use |
|
Lintcheck changes for 81ce47a
This comment will be updated if you push new changes |
| /// The outermost `impl Deref` we're currently in. While we're in one, | ||
| /// `explicit_deref_methods` is deactivated for `deref` | ||
| outermost_deref_impl: Option<OwnerId>, | ||
|
|
||
| /// The outermost `impl DerefMut` we're currently in. While we're in one, | ||
| /// `explicit_deref_methods` is deactivated for `deref_mut` | ||
| outermost_derefmut_impl: Option<OwnerId>, |
There was a problem hiding this comment.
Why not keep only one of them? The lint description says it doesn't lint inside Deref or DerefMut implementation, so that would be enough.
ada4a
force-pushed
the
15392-explicit_deref_methods
branch
from
e2a228b to
abd09bf
Compare
|
@rustbot ready |
ada4a
force-pushed
the
15392-explicit_deref_methods
branch
from
abd09bf to
22c4a6b
Compare
|
The CI failure is caused by actions/download-artifact#381, but it seems to happen only some of the time. Therefore, rerunning CI should help, but apparently I don't have the rights to do that -- could you do it please? |
I've run it again, but it didn't solve it. Can you do a no-op push (just reset the committer date for example and force push)? |
|
I could add it to the queue, but I would prefer to see the lintcheck result first. |
ada4a
force-pushed
the
15392-explicit_deref_methods
branch
from
22c4a6b to
81ce47a
Compare
rustbot
removed
the
S-waiting-on-review
3 participants
Resolves #15392
Resurrection of #15688
changelog: [
explicit_deref_methods]: don't lint inimpl Deref(Mut)