Skip to content

allow explicit deref or deref_mut method calls in impl of Deref or DerefMut trait#15688

Closed
relaxcn wants to merge 1 commit intorust-lang:masterfrom
relaxcn:i-15392
Closed

allow explicit deref or deref_mut method calls in impl of Deref or DerefMut trait#15688
relaxcn wants to merge 1 commit intorust-lang:masterfrom
relaxcn:i-15392

Conversation

@relaxcn
Copy link
Copy Markdown
Contributor

@relaxcn relaxcn commented Sep 16, 2025 •
edited
Loading

Fixes: #15392

changelog: [explicit_deref_methods]: Allow explicit deref or deref_mut method calls in implementation of the the Deref or DerefMut trait.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 16, 2025
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Sep 16, 2025

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 16, 2025 •
edited
Loading

Lintcheck changes for 0e70271

Lint Added Removed Changed
clippy::explicit_deref_methods 0 1 0

This comment will be updated if you push new changes

@rustbot

This comment has been minimized.

Sign in to view
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Oct 8, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@relaxcn
Copy link
Copy Markdown
Contributor Author

relaxcn commented Oct 8, 2025

r? clippy

@rustbot rustbot assigned Alexendoo and unassigned y21 Oct 8, 2025
ada4a
ada4a requested changes Oct 11, 2025
View reviewed changes
Comment thread clippy_lints/src/dereference.rs Outdated
@relaxcn relaxcn changed the title allow explicit deref method call in deref or deref_mut impl of `D… allow explicit deref method call in deref impl of Deref trait Oct 12, 2025
@relaxcn relaxcn changed the title allow explicit deref method call in deref impl of Deref trait allow explicit deref or deref_mut method calls in impl of Deref or DerefMut trait Oct 13, 2025
@relaxcn
Copy link
Copy Markdown
Contributor Author

relaxcn commented Oct 13, 2025

@rustbot ready

@relaxcn relaxcn requested a review from ada4a October 23, 2025 03:08
ada4a
ada4a approved these changes Oct 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ada4a ada4a left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the possible confusion @relaxcn – I'm not actually a member of the Clippy Team and so I unfortunately can't merge this PR. But I think it's in a pretty good shape now, and we'll just need to wait for the actual reviewer to take a final look and approve – the reviewers are usually quite busy, so it can take a bit 😅

View changes since this review

Comment thread clippy_lints/src/dereference.rs Outdated
Comment thread clippy_lints/src/dereference.rs Outdated
@ada4a
Copy link
Copy Markdown
Contributor

ada4a commented Oct 23, 2025

@y21 friendly ping

samueltardieu
samueltardieu requested changes Oct 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@samueltardieu samueltardieu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? samueltardieu
@rustbot author

View changes since this review

Comment thread clippy_lints/src/dereference.rs Outdated
Comment thread clippy_lints/src/dereference.rs Outdated
@rustbot rustbot assigned samueltardieu and unassigned Alexendoo Oct 23, 2025
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Oct 23, 2025
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Oct 23, 2025

Reminder, once the PR becomes ready for a review, use @rustbot ready.

@samueltardieu samueltardieu mentioned this pull request Oct 23, 2025
Closed
@relaxcn
Copy link
Copy Markdown
Contributor Author

relaxcn commented Oct 25, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Oct 25, 2025
@relaxcn relaxcn closed this Oct 31, 2025
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 31, 2025
@ada4a ada4a added the S-inactive-closed Status: Closed due to inactivity label Nov 12, 2025
@ada4a ada4a mentioned this pull request Nov 18, 2025
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Nov 21, 2025
@samueltardieu
feat(explicit_deref_methods): don't lint in impl Deref(Mut) (#16113)
37b485b 
Resolves #15392
Resurrection of #15688

changelog: [`explicit_deref_methods`]: don't lint in `impl Deref(Mut)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samueltardieu samueltardieu samueltardieu requested changes

@ada4a ada4a ada4a approved these changes

Assignees

@samueltardieu samueltardieu

Labels

S-inactive-closed Status: Closed due to inactivity

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow explicit_deref_methods in Deref impls

6 participants

@relaxcn @rustbot @ada4a @samueltardieu @Alexendoo @y21