Skip to content

Fix module_name_repetitions FP on exported macros #15319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
blyxyas merged 1 commit into from
Jul 23, 2025
Merged

Fix module_name_repetitions FP on exported macros #15319

blyxyas merged 1 commit into from
Jul 23, 2025

Conversation

@profetia
Copy link
Contributor

@profetia profetia commented Jul 21, 2025 •
edited by rustbot
Loading

Closes #14095

changelog: [module_name_repetitions] fix FP on exported macros

@rustbot
Copy link
Collaborator

rustbot commented Jul 21, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 21, 2025
@github-actions
Copy link

github-actions bot commented Jul 21, 2025

Lintcheck changes for bebae76

Lint Added Removed Changed
clippy::module_name_repetitions 0 4 0

This comment will be updated if you push new changes

blyxyas
blyxyas approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! ❤️

@blyxyas blyxyas added this pull request to the merge queue Jul 23, 2025
Merged via the queue into rust-lang:master with commit 8ad5c67 Jul 23, 2025
11 of 13 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 23, 2025
@profetia profetia deleted the issue14095 branch September 12, 2025 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blyxyas blyxyas blyxyas approved these changes

Assignees

@blyxyas blyxyas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

module_name_repetitions on exported macros should use crate name, not module name

3 participants

@profetia @rustbot @blyxyas