Skip to content

Reduce clippy lints page size#15235

Merged
samueltardieu merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:reduce-lint-pages
Jul 11, 2025
Merged

Reduce clippy lints page size#15235
samueltardieu merged 1 commit intorust-lang:masterfrom
GuillaumeGomez:reduce-lint-pages

Conversation

@GuillaumeGomez
Copy link
Copy Markdown
Member

@GuillaumeGomez GuillaumeGomez commented Jul 9, 2025

Follow-up of #15208.

Removed some unneeded wrappings and shortened some CSS class name.

The diff is big because of one indent level getting removed. :-/

Before this PR: 1751301
With this PR: 1663634
Reduction: -5%

r? @samueltardieu

changelog: Reduce page size and number of DOM elements on clippy lints page

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 9, 2025
@samueltardieu
Copy link
Copy Markdown
Member

samueltardieu commented Jul 11, 2025

I got this in the console once

Uncaught TypeError: can't access property "innerText", elem.querySelector(...) is null
    allLints http://localhost:8000/script.js:253
    getAllLints http://localhost:8000/script.js:245
    filterLints http://localhost:8000/script.js:323
    <anonymous> http://localhost:8000/script.js:611
[script.js:253:33](http://localhost:8000/script.js)
    allLints http://localhost:8000/script.js:253
    map self-hosted:175
    getAllLints http://localhost:8000/script.js:245
    filterLints http://localhost:8000/script.js:323

but can't reproduce it. I'll assume this was a transient problem on my side.

@samueltardieu samueltardieu added this pull request to the merge queue Jul 11, 2025
Merged via the queue into rust-lang:master with commit e2270bb Jul 11, 2025
8 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 11, 2025
@GuillaumeGomez GuillaumeGomez deleted the reduce-lint-pages branch July 11, 2025 09:23
@GuillaumeGomez
Copy link
Copy Markdown
Member Author

GuillaumeGomez commented Jul 11, 2025

Maybe it loaded the old script initially? Strange. Thanks for taking a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@samueltardieu samueltardieu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez @samueltardieu @rustbot