Simplify clippy lints page further#15208
Merged
samueltardieu merged 1 commit intorust-lang:masterfrom Jul 4, 2025
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Member
|
Seems to be working fine for me without errors. |
rustbot
removed
the
S-waiting-on-review
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
Follow-up of #15208. Removed some unneeded wrappings and shortened some CSS class name. The diff is big because of one indent level getting removed. :-/ Before this PR: 1751301 With this PR: 1663634 Reduction: -5% r? @samueltardieu changelog: Reduce page size and number of DOM elements on clippy lints page
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Aug 6, 2025
Follow-up of #15208. This PR removes the CSS `bootstrap` dependency which contains 1504 CSS rules and weights 16.1 kB minified. Considering we used less than 50 of these rules, it's quite a waste. So this time, there are minor UI changes: * The "expand/collapse all" buttons icon changed. It now uses the one from font-awesome. It's quite close but not exactly the same. * The layout is slightly different (you need to switch between two tabs to actually see the difference). Before this PR: <img width="719" height="515" alt="image" src="https://github.com/user-attachments/assets/1f067046-4ee9-49ee-bf38-50a8bf9888f2" /> With this PR: <img width="719" height="515" alt="image" src="https://github.com/user-attachments/assets/80331c98-1a1e-418f-b481-5b3f5c276926" /> With this, we will be able to go even further on reducing the page size next. =D This time, the DOM size itself reduced a bit but the difference is too small to be noteworthy. r? @samueltardieu changelog: Remove CSS bootstrap dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #15140.
This time, I removed some unneeded
<span>wrappings and some unneeded CSS classes. As usual, no changes in the UI.Before this PR: 1876091
With this PR: 1751097
Reduction: -6.6%
r? @samueltardieu
changelog: Reduce page size and number of DOM elements on clippy lints page