Use is_diagnostic_item for checking a def_id in unnecessary_min_or_max.
#13235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rustbot
added
the
S-waiting-on-review
kyoto7250
force-pushed
the
fix_issue_13191
branch
from
f8cab30 to
0c535f8
Compare
kyoto7250
force-pushed
the
fix_issue_13191
branch
from
0c535f8 to
c2ed04b
Compare
kyoto7250
changed the title
match_def_pathis_diagnostic_item for checking a def_id in unnecessary_min_or_max.
Contributor
|
Looks good to me. Thank you for this improvement. @bors r+ |
Contributor
Contributor
bors
added a commit
that referenced
this pull request
Aug 26, 2024
Use `is_diagnostic_item` for checking a def_id in `unnecessary_min_or_max`. close #13191 This PR fixes the false positives in `unnecessary_min_or_max `. We should use `is_diagnostic_item` for checking def_ids in this lint. ---- changelog: fix false positive in `unnecessary_min_or_max `
Contributor
|
💔 Test failed - checks-action_test |
Contributor
|
@bors retry |
Contributor
bors
added a commit
that referenced
this pull request
Aug 26, 2024
Use `is_diagnostic_item` for checking a def_id in `unnecessary_min_or_max`. close #13191 This PR fixes the false positives in `unnecessary_min_or_max `. We should use `is_diagnostic_item` for checking def_ids in this lint. ---- changelog: fix false positive in `unnecessary_min_or_max `
Contributor
|
💔 Test failed - checks-action_test |
Contributor
Author
|
@llogiq |
Member
|
@bors retry |
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13191
This PR fixes the false positives in
unnecessary_min_or_max.We should use
is_diagnostic_itemfor checking def_ids in this lint.changelog: fix false positive in
unnecessary_min_or_max.