Skip to content

Conversation

@xFrednet
Copy link
Contributor

Roses are red,
violets are blue,
new format is tried,
it's way less of a fight


Hey @rust-lang/clippy, @blyxyas, and @Centri3, I've tried the "new"/minimal changelog format we discussed a few meetings ago. I like it, and the writing process was also way quicker.

🖼️ Rendered 🖼️

Furthermore, a big thank you to @blyxyas and @Alexendoo for updating the script that fetches the PR commits and adding links to the config values to the changelog. ❤️


changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jul 11, 2023

r? @Alexendoo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jul 11, 2023
@flip1995
Copy link
Member

Thanks! I think we can merge this. It will be a bit time-travel-y but that's fine.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 12, 2023

📌 Commit 7a3756a has been approved by flip1995

It is now in the queue for this repository.

@flip1995
Copy link
Member

Why the crown in the title? 🤔

@xFrednet
Copy link
Contributor Author

Why the crown in the title? 🤔

I add a different emoji to each changelog commit. It's just some stupid fun, like the poem. The story behind each emoji is different, sometimes it's simply one recommended by a friend, a meme, or so.

The crown is a reference to the bors merge comments I've used lately ^^

Does that explain it or make it more confusion? xD

@flip1995
Copy link
Member

flip1995 commented Jul 12, 2023

That explains it perfectly! Now I also know about the emoji lore :D

bors is stuck currently, fyi.

@bors
Copy link
Contributor

bors commented Jul 12, 2023

⌛ Testing commit 7a3756a with merge d398e59...

@bors
Copy link
Contributor

bors commented Jul 12, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing d398e59 to master...

@bors bors merged commit d398e59 into rust-lang:master Jul 12, 2023
@xFrednet xFrednet deleted the changelog-1-71 branch July 12, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants