[unnecessary_literal_unwrap]: also lint unwrap_(err_)unchecked
#11098
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @giraffate (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
Member
|
This could probably check |
y21
changed the title
unnecessary_literal_unwrap]: also lint unwrap_uncheckedunnecessary_literal_unwrap]: also lint unwrap_(err_)unchecked
Contributor
|
☔ The latest upstream changes (presumably #11110) made this pull request unmergeable. Please resolve the merge conflicts. |
giraffate
approved these changes
Jul 11, 2023
Contributor
giraffate
left a comment
giraffate
left a comment
There was a problem hiding this comment.
Overall looks good, thanks!
Can we resolve the conflicts?
Contributor
|
@bors r+ Thanks! |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11093
changelog: [
unnecessary_literal_unwrap]: also lintunwrap_uncheckedandunwrap_err_unchecked