Add size-parameter to unecessary_box_returns #10651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
the
S-waiting-on-review
xFrednet
approved these changes
Apr 19, 2023
Contributor
xFrednet
left a comment
xFrednet
left a comment
There was a problem hiding this comment.
LGTM, tiny nit related to the lint documentation comment. It requires some specific syntax. :)
clippy_lints/src/utils/conf.rs
Outdated
| /// | ||
| /// The maximum byte size a `Future` can have, before it triggers the `clippy::large_futures` lint | ||
| (future_size_threshold: u64 = 16 * 1024), | ||
| /// Lint: UNNECESSARY_BOX_RETURNS, |
Contributor
There was a problem hiding this comment.
Suggested change
| /// Lint: UNNECESSARY_BOX_RETURNS, | |
| /// Lint: UNNECESSARY_BOX_RETURNS. |
This list requires a dot at the end, to be parsed correctly. Once you do this, you also have to run cargo collect-matadata to update the lint configuration list in our book.
Contributor
|
Thank you! You can @bors delegate+ |
Contributor
|
✌️ @lukaslueg can now approve this pull request |
Contributor
Author
|
@bors r=xFrednet |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10641
This adds a configuration-knob to the
unecessary_box_returns-lint which allows not linting afn() -> Box<T>ifTis "large". The default byte size above which we no longer lint is 128 bytes (due to #4652 (comment), also used in #9373). The overall rational is given in #10641.changelog: Enhancement: [
unnecessary_box_returns]: Added new lint configurationunnecessary-box-sizeto set the maximum size ofTinBox<T>to be linted#10651