prevent panic when compiling aarch64 vectorcall functions#2694
Merged
emilio merged 1 commit intorust-lang:mainfrom Dec 11, 2023
Merged
prevent panic when compiling aarch64 vectorcall functions#2694emilio merged 1 commit intorust-lang:mainfrom
emilio merged 1 commit intorust-lang:mainfrom
Conversation
emilio
approved these changes
Dec 11, 2023
Contributor
|
Seems hard to automatically test unfortunately. Maybe copy-paste the relevant code from math.h into a test file and add a test with the right target flags? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"vectorcall" and "aarch64 vectorcall" are the same calling conventions only for different architectures, is it right?
closes #2693