Skip to content

Conversation

@pvdrz
Copy link
Contributor

@pvdrz pvdrz commented Sep 12, 2022

Apparently #2270 introduced several bugs:

  • The RegexSet for --newtype-global-enum was not initialized correctly.
  • The flag was not emitted when the option was used either.
  • The generated bindings did not use a newtype.

All three have been fixed here.

@pvdrz pvdrz requested review from emilio and kulp and removed request for emilio September 12, 2022 18:49
@pvdrz pvdrz mentioned this pull request Sep 12, 2022
@pvdrz pvdrz force-pushed the fix-newtype-global-enum branch from 47a3a6e to 0ffe307 Compare September 12, 2022 18:50
@kulp
Copy link
Member

kulp commented Sep 14, 2022

Apparently #2270 introduced several bugs:

Well, that shows how much I did not know!

I will take a look at this again soon when I am more alert, unless @emilio gets to it first. Thanks for addressing these issues.

Copy link
Member

@kulp kulp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Thanks again!

@kulp kulp merged commit 0d805d7 into rust-lang:master Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants