Offer replace_arith on references to ints - #23109
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
reviewed
Aug 11, 2026
ronnodas
force-pushed
the
replace-arith-ref
branch
from
August 11, 2026 16:59
d6dfa09 to
c8a4429
Compare
This comment has been minimized.
This comment has been minimized.
ronnodas
force-pushed
the
replace-arith-ref
branch
from
August 12, 2026 00:28
c8a4429 to
5e6e4e6
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
A4-Tacks
approved these changes
Aug 12, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the `Replace arithmetic" assist is only offered when both operands are integers types, but it should be also applicable when they are references to such.