Skip to content

internal: Support multiple stable releases in one day - #23108

Merged
lnicola merged 1 commit into
rust-lang:masterfrom
lnicola:release-suffix
Aug 10, 2026
Merged

internal: Support multiple stable releases in one day#23108
lnicola merged 1 commit into
rust-lang:masterfrom
lnicola:release-suffix

Conversation

@lnicola

@lnicola lnicola commented Aug 10, 2026

Copy link
Copy Markdown
Member

AI disclosure: this was largely written by Gemini Flash 3.6 with some prodding to use awk instead of a loop. I have reviewed and mostly understood it.

Fixes #20451

@lnicola lnicola changed the title Support multiple stable releases in one day internal: Support multiple stable releases in one day Aug 10, 2026
@lnicola
lnicola marked this pull request as ready for review August 10, 2026 12:17
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2026
@lnicola

lnicola commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

r? @Veykril

@lnicola

lnicola commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

FWIW, I'd like to merge this today and cut a new release because the original one is bugged, and it's a good opportunity to test it.

Draft run here, without any release assets.

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

I have reviewed and mostly understood it.

Normally this wouldn't be enough, but nobody fully understands GitHub's YAML and bash, so...

I don't feel qualified to review this myself though.

@lnicola

lnicola commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

I think I understand the AWK script, but I've almost never written AWK so..

@nicolas-guichard

nicolas-guichard commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

If you're not married to awk, I think that's easier to understand:

last_tag="$(git tag -l "${today}*" | sort | tail -n1)"
if [ "$last_tag" ]; then
    last_v=$(echo "$last_tag" | grep -oP '(?<=\.)\d+' || echo 0)
    new_v=$(($last_v + 1))
    tag="${today}.${new_v}"
else
    tag="$today"
fi

@lnicola

lnicola commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

I think that's easier to understand

I'm not sure, but I switched to your version, changed to if [ -n ... ] and sort -V. I hope we won't have 10 releases in one day though.

@lnicola
lnicola enabled auto-merge August 10, 2026 14:28
@lnicola
lnicola added this pull request to the merge queue Aug 10, 2026
Merged via the queue into rust-lang:master with commit f938641 Aug 10, 2026
30 of 36 checks passed
@lnicola
lnicola deleted the release-suffix branch August 10, 2026 14:46
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Source of tag 2025-08-11 changed content

5 participants