fix!: make lsp-server Response type closer aligned to JSON-RPC#22753
Merged
Conversation
From [the JSON-RPC 2.0 protocol](https://www.jsonrpc.org/specification#response_object): > result > This member is REQUIRED on success. > This member MUST NOT exist if there was an error invoking the method. > The value of this member is determined by the method invoked on the Server. > error > This member is REQUIRED on error. > This member MUST NOT exist if there was no error triggered during invocation. > The value for this member MUST be an Object as defined in section 5.1. > > ... > > Either the result member or error member MUST be included, but both members MUST NOT be included. The current typing of the `Response` object allows both the `result` and `error` members to be present, or for neither to be present. This commit strengthens the typing of the response to prevent these cases from being expressed. This is a breaking change. The response kind definition is borrowed from the [tower-lsp](https://github.com/ebkalderon/tower-lsp) definition.
rustbot
added
the
S-waiting-on-review
Veykril
approved these changes
Jul 11, 2026
Member
|
Thanks! |
rustbot
removed
the
S-waiting-on-review
Contributor
|
Shouldn't we, then, just use |
Contributor
Author
|
Good point- I'll draft a PR |
ribru17
added a commit
to ribru17/rust-analyzer
that referenced
this pull request
Jul 14, 2026
We don't need a new type here thanks to serde's `remote`. This is a follow-up to rust-lang#22753 (comment).
ribru17
added a commit
to ribru17/rust-analyzer
that referenced
this pull request
Jul 16, 2026
We don't need a new type here thanks to serde's `remote`. This is a follow-up to rust-lang#22753 (comment).
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Jul 20, 2026
We don't need a new type here thanks to serde's `remote`. This is a follow-up to rust-lang/rust-analyzer#22753 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From the JSON-RPC 2.0 protocol:
The current typing of the
Responseobject allows both theresultanderrormembers to be present, or for neither to be present. This commit strengthens the typing of the response to prevent these cases from being expressed. This is a breaking change.The response kind definition is borrowed from the
tower-lsp definition.