Migrate merge imports to editor - #22351
Merged
Veykril merged 11 commits intoJun 20, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
bit-aloo
force-pushed
the
2026-05-10-migrate-merge-imports-to-editor
branch
4 times, most recently
from
May 13, 2026 04:34
d144bca to
935f981
Compare
ChayimFriedman2
previously requested changes
May 24, 2026
bit-aloo
force-pushed
the
2026-05-10-migrate-merge-imports-to-editor
branch
from
May 25, 2026 17:34
935f981 to
d1fc4ad
Compare
bit-aloo
force-pushed
the
2026-05-10-migrate-merge-imports-to-editor
branch
from
May 26, 2026 06:09
d1fc4ad to
f5e3520
Compare
bit-aloo
force-pushed
the
2026-05-10-migrate-merge-imports-to-editor
branch
from
June 3, 2026 02:55
f5e3520 to
d800e4d
Compare
This comment has been minimized.
This comment has been minimized.
Merged
This comment has been minimized.
This comment has been minimized.
bit-aloo
force-pushed
the
2026-05-10-migrate-merge-imports-to-editor
branch
from
June 12, 2026 09:36
d800e4d to
0015ecd
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
…t APIs try_merge_imports, try_merge_trees, and try_normalize_import only ever used the editor to obtain its SyntaxFactory; they never edited through it.
ast::edit had private inherent ast::Use::remove and ast::UseTree::remove_with_editor methods that duplicated the
Veykril
approved these changes
Jun 20, 2026
Veykril
enabled auto-merge
June 20, 2026 15:47
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #15710 and #18285