Fix debug sourceFileMap when using cppvsdbg #19475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
inflation
commented
Mar 29, 2025
inflation
commented
- Fix Failed to map Rust stdlib sources when debugging in Windows #18782
rustbot
added
the
S-waiting-on-review
|
Kindly ping @davidbarsky on why it was changed in the first place (f25cb19). Is it intentional for |
|
I don’t remember. In my testing, I don’t think either lldb-dap or CodeLLDB needed the commit hash, but I wasn’t particularly thorough in my testing. |
|
To me, it looks like |
|
By the way, llvm/llvm-project#106919 is now merged. |
|
I think that change was merged when I wrote the commit where I refactored this code, but there wasn’t an lldb (or lldb-dap) release containing said changes. I think there might be one now? |
|
Yeah, there is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.