chore: Remove salsa dependency from proc-macro server again #19457
+63
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
commented
Mar 26, 2025
.github/workflows/ci.yaml
Outdated
Comment on lines
73
to
77
| - run: | | ||
| if cargo tree -p proc-macro-srv-cli | grep -q 'salsa'; then | ||
| echo "The proc-macro server may not depend on salsa" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
can this be done more concisely?
There was a problem hiding this comment.
! (cargo tree -p proc-macro-srv-cli | grep -q salsa) maybe?
Veykril
force-pushed
the
push-xpmluxlzprpy
branch
2 times, most recently
from
3a681d2 to
a1c3895
Compare
davidbarsky
approved these changes
Mar 26, 2025
Veykril
force-pushed
the
push-xpmluxlzprpy
branch
2 times, most recently
from
b23d99a to
9a5a513
Compare
Veykril
force-pushed
the
push-xpmluxlzprpy
branch
from
9a5a513 to
7b9e091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.