Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: don't panic when the crate graph isn't ready #19351

Merged
merged 1 commit into from
Mar 13, 2025
Merged

internal: don't panic when the crate graph isn't ready #19351

merged 1 commit into from
Mar 13, 2025

Conversation

davidbarsky
Copy link
Contributor

This comes up when using rust-analyzer with the project discovery functionality (e.g., with Buck or Bazel), as rust-analyzer has started, but the crate graph isn't populated yet. I chose to return with an empty set of diagnostics instead of panicking.

@ChayimFriedman2: I think this qualifies as RootQueryDb::all_crates being used in query analysis?

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2025
@ChayimFriedman2
Copy link
Contributor

ide-diagnostics isn't analysis. Analysis is hir-* crates. The problem with them is that if they depend on all_crates they'll be invalidated when they change, a problem that doesn't exist for ide-* crates (because they don't form queries).

We do however have a bunch of other places where we call db.all_crates().last().unwrap().

@davidbarsky
Copy link
Contributor Author

ide-diagnostics isn't analysis. Analysis is hir-* crates.

Ah, gotcha: I'll update the comments to say hir-* crates instead of a general "analysis".

We do however have a bunch of other places where we call db.all_crates().last().unwrap().

SemanticsImpl::first_crate_or_default is another, which panicked with when I hovered over something.

@ChayimFriedman2
Copy link
Contributor

We do however have a bunch of other places where we call db.all_crates().last().unwrap().

SemanticsImpl::first_crate_or_default is another, which panicked with when I hovered over something.

Yes, and there are few others. I suggest you search for this pattern.

@davidbarsky davidbarsky force-pushed the davidbarsky/fix-panic-in-diagnostics branch from 1234fac to bb80b01 Compare March 13, 2025 18:33
@davidbarsky
Copy link
Contributor Author

We do however have a bunch of other places where we call db.all_crates().last().unwrap().

SemanticsImpl::first_crate_or_default is another, which panicked with when I hovered over something.

Yes, and there are few others. I suggest you search for this pattern.

Sorry, I should've been clearer: I did and saw them. I was just looking at code that code cause panics during startup. I'll fix the rest in a second.

ChayimFriedman2
ChayimFriedman2 approved these changes Mar 13, 2025
View reviewed changes
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with few small nits.

@davidbarsky davidbarsky force-pushed the davidbarsky/fix-panic-in-diagnostics branch from bb80b01 to 311f96e Compare March 13, 2025 19:13
@davidbarsky davidbarsky changed the title internal: fix a panic in diagnostics when the crate graph isn't yet populated internal: don't panic when the crate graph isn't ready Mar 13, 2025
@davidbarsky davidbarsky force-pushed the davidbarsky/fix-panic-in-diagnostics branch from 311f96e to 788232b Compare March 13, 2025 19:14
@davidbarsky davidbarsky added this pull request to the merge queue Mar 13, 2025
Merged via the queue into rust-lang:master with commit 185f9de Mar 13, 2025
9 checks passed
@davidbarsky davidbarsky deleted the davidbarsky/fix-panic-in-diagnostics branch March 13, 2025 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChayimFriedman2 ChayimFriedman2 ChayimFriedman2 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidbarsky @ChayimFriedman2 @rustbot