Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icons to views #19344

Merged
merged 1 commit into from
Mar 16, 2025
Merged

Add icons to views #19344

merged 1 commit into from
Mar 16, 2025

Conversation

BenjaminBrienen
Copy link
Contributor

@BenjaminBrienen BenjaminBrienen commented Mar 11, 2025 •
edited
Loading

Noticed this:
image

image

See the sidebar icon

Screencast.from.03-11-2025.08.38.12.PM.webm

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2025
@BenjaminBrienen
Copy link
Contributor Author

Let me know if there is a better icon to use.

https://code.visualstudio.com/api/references/icons-in-labels

@BenjaminBrienen
Copy link
Contributor Author

Maybe package for explorer/Rust Dependencies?
image

@BenjaminBrienen
Copy link
Contributor Author

I can't test the Show Syntax Tree icon due to this error when I turn on the setting:

[Error - 8:35:40 PM] Stopping server timed out

thread 'Worker' panicked at crates/rust-analyzer/src/reload.rs:376:87:
called `Result::unwrap()` on an `Err` value: "SendError(..)"
stack backtrace:
[Error - 8:35:40 PM] Server process exited with code 0.

2025-03-11 20:35:41.020 [error] Error: Client is not running
	at RaLanguageClient.sendNotification (/home/techn0/source/rust-analyzer/editors/code/out/main.js:15164:33)
	at /home/techn0/source/rust-analyzer/editors/code/out/main.js:23126:25
	at Th.value (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:172:35535)
	at P.B (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:27:2375)
	at P.C (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:27:2445)
	at P.fire (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:27:2662)
	at wM.$acceptConfigurationChanged (file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:112:3150)
	at file:///usr/share/code/resources/app/out/vs/workbench/api/node/extensionHostProcess.js:112:2700

@BenjaminBrienen
Copy link
Contributor Author

It only fails on the extension development host, though. It works on master.

@BenjaminBrienen
Copy link
Contributor Author

Nevermind, it seems broken on the released version as well
image

Veykril
Veykril approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Veykril Veykril added this pull request to the merge queue Mar 16, 2025
Merged via the queue into rust-lang:master with commit 6675b58 Mar 16, 2025
10 checks passed
@lnicola
Copy link
Member

lnicola commented Mar 17, 2025

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BenjaminBrienen @lnicola @Veykril @rustbot