internal: Run proc-macro server tests as separate CI job #19328
Merged
+45
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Merged
Veykril
force-pushed
the
push-umwykvoskvyp
branch
from
4a3aeea to
0b009b4
Compare
Veykril
changed the title
Veykril
force-pushed
the
push-umwykvoskvyp
branch
from
0b009b4 to
3cddac3
Compare
Veykril
commented
Mar 10, 2025
Comment on lines
-98
to
+125
| run: cargo test ${{ env.USE_SYSROOT_ABI }} -- --nocapture --quiet | ||
| run: cargo test -- --quiet |
There was a problem hiding this comment.
I dropped the --nocapture here, I am not sure what the benefit for us here is to run CI with it but now that our doc tests are being tested this adds noise for each compilefail test
BenjaminBrienen
approved these changes
Mar 10, 2025
Veykril
force-pushed
the
push-umwykvoskvyp
branch
from
3cddac3 to
88ab330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.