Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum supported toolchain to 1.82 #19275

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented Mar 3, 2025

Closes #19272

r? @Veykril not sure whether you want to look into this

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2025
@Veykril
Copy link
Member

Veykril commented Mar 3, 2025

We didn't change anything significant the past 2 weeks though did we? 🤔

@lnicola
Copy link
Member Author

lnicola commented Mar 3, 2025

I didn't bisect, but we're not loading the sysroot any more on 1.81.

@Veykril
Copy link
Member

Veykril commented Mar 3, 2025

Oh right, we dropped the sysroot stitching support #19096, somehow I thought the sysroot workspace change was older than 1.82

@Veykril Veykril added this pull request to the merge queue Mar 3, 2025
@Veykril
Copy link
Member

Veykril commented Mar 3, 2025

Unsure if we want to bump to 1.82 or undo that part of the PR tbh. Merging this either way for now

Merged via the queue into rust-lang:master with commit 02862f5 Mar 3, 2025
9 checks passed
@lnicola lnicola deleted the min-1-82 branch March 3, 2025 14:41
@Veykril
Copy link
Member

Veykril commented Mar 4, 2025

Do ew want to make another quick release so people get the warning?

@lnicola
Copy link
Member Author

lnicola commented Mar 4, 2025

Sure, I've triggered one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of suggestions v0.3.2328 VSC Windows
3 participants