Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Add tabstop to impl body in generate_trait_impl assist #19221

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

Giga-Bowser
Copy link
Contributor

This matches the behavior of the generate_impl assist.

I have no idea what this assist-doc demorgan cruft getting pulled along is but if it's just something #19171 forgot to do I'm fine having it done here.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 24, 2025
@lnicola
Copy link
Member

lnicola commented Feb 24, 2025

Yeah, don't worry about the doc changes, cargo test does that.

@lnicola lnicola enabled auto-merge February 24, 2025 19:15
@lnicola lnicola added this pull request to the merge queue Feb 24, 2025
Merged via the queue into rust-lang:master with commit 3bb49be Feb 24, 2025
9 checks passed
@Giga-Bowser Giga-Bowser deleted the generate-trait-impl-tabstop branch February 24, 2025 22:00
@ShoyuVanilla
Copy link
Member

I have no idea what this assist-doc demorgan cruft getting pulled along is but if it's just something #19171 forgot to do I'm fine having it done here.

I forgot to generate docs 😅 Thanks!

@lnicola
Copy link
Member

lnicola commented Feb 25, 2025

I'm not sure if we want to have those under git, but if we do, we probably want a test for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants